Fix the topology_ function #604
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add NOTOPOS and NOSYMMETRYFACTOR flags to control the inclusion of topo_ and symmetry factors. - Set an appropriate default value for the optional last argument of the topologies_ function. - Fix missing/wrong initialization of info and TopoInf. - Avoid unnecessary heap allocation.
The expected result for the Diagrams_3 test case is updated while remaining consistent with the old result because of the symmetry of interchanging the external legs. For now, the node IDs are decremented in the test code to reproduce the old results.
|
Question: Are these changes acceptable?
Another question about the diagram generator is why the name |
|
There is also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #474.
Internally, 2 new flags
NOTOPOSandNOSYMMETRYFACTORhave been introduced. These flags are not yet exposed to users as preprocessor variables.For now, node numbers start from 1.
The result of Diagram_3 has been updated:
but they are actually the same. The old and new diagrams are equivalent when considering the symmetry that arises from interchanging the two external legs:
I am not sure about the diagram generator options for
NOSNAILS_,NOTADPOLES_, etc., as they have not yet been tested.