Skip to content

added string to language type #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

added string to language type #1136

merged 1 commit into from
Jun 11, 2025

Conversation

ZenMasterJacob20011
Copy link
Contributor

@ZenMasterJacob20011 ZenMasterJacob20011 commented May 7, 2025

https://formio.atlassian.net/browse/FIO-10134

Link to Jira Ticket

N/A

Description

What changed?

Added string to language type

Why have you chosen this solution?

We have a typeof check for language to be type of string. Seems like we missed adding the type def of string to language

Breaking Changes / Backwards Compatibility

N/A

Dependencies

N/A

How has this PR been tested?

N/A

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit bfc8600 into master Jun 11, 2025
2 of 4 checks passed
@brendanbond brendanbond deleted the add-string-type-to-lang branch June 11, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants