Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7954: fixed translations #5957

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Dec 27, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7954

Description

What changed?

  • refactored translations and moved all hardcoded translated strings to single file;
  • added ability to extend default translations by formio modules using Formio.use
  • added backward compatibility for cases where the entire phrase is used as a key for translation

Dependencies

https://github.com/formio/premium/pull/364
https://github.com/formio/reporting/pull/52
formio/bootstrap#121
https://github.com/formio/grid/pull/64

How has this PR been tested?

Manually + tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold marked this pull request as draft December 27, 2024 15:24
@TanyaGashtold TanyaGashtold marked this pull request as ready for review December 30, 2024 12:25
@brendanbond brendanbond merged commit a36bb25 into master Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants