Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the embed code to export the Formio construct. #5969

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

travist
Copy link
Member

@travist travist commented Jan 5, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9552

Description

The "formio.embed.js" file on the CDN was throwing an error that the "Formio" class was undefined. Turns out, this was not getting exported and picked up on by Webpack so it was not getting defined as a global. This simply ensures that it is exported so that it will be defined globally.

Breaking Changes / Backwards Compatibility

None

Dependencies

None

How has this PR been tested?

Manual

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit d30be67 into master Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants