FIO-9618: Move I18n shim to core #6042
Open
+56
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakekrammes
force-pushed
the
fio-9618
branch
2 times, most recently
from
a363e8d to
958f667
Compare
blakekrammes
force-pushed
the
fio-9618
branch
3 times, most recently
from
4de8bfd to
5115a9c
Compare
- Move relevant translation strings to core - Add form language to submission metadata
- Change to eachComponentData in core shows 2 wizard errors instead of 1, which I believe is the correct behavior - Relevant commit formio/core@fc8960e#diff-9b18bb8f4f70621ee3d4d779a4293139a5ede3ac9d714d46560027a5e0750faaR86
blakekrammes
commented
Apr 11, 2025
| @@ -563,9 +563,13 @@ describe('Wizard Form with Nested Form validation', () => { | |||
| setTimeout(() => { | |||
| checkPage(2); | |||
| const errors = wizard.errors; | |||
| assert.equal(errors.length, 1, 'Must err before next page'); | |||
| assert.equal(errors.length, 2, 'Must err before next page'); | |||
There was a problem hiding this comment.
the nested wizard has two required fields on the same page:
- formNested.data.textField
- formNested.data.dataGrid[0].textField
both are required and should show up in the validation errors, I believe
There was a problem hiding this comment.
this commit in core added a new check in eachComponentData that causes both errors to show
formio/core@fc8960e#diff-9b18bb8f4f70621ee3d4d779a4293139a5ede3ac9d714d46560027a5e0750faaR86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9618
Description
What changed?
As part of the move to render emails in a core processor instead of formio.js, it was necessary to enable I18n translation in core, thus moving the shim from here to there. Since translation is not directly related to rendering formio components it was deemed fitting to move this to core. I have also moved relevant translation strings to core (many of the errors were already present there and have been removed here). The translations left in formio.js should only relate to frontend concerns.
Why have you chosen this solution?
Use this section to justify your choices
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
formio/core#235
How has this PR been tested?
Manually
Checklist: