Skip to content

FIO-9813: Add validate when hidden property to the Nested Form if any of the children has it #6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexandraRamanenka
Copy link
Contributor

@alexandraRamanenka alexandraRamanenka commented Mar 13, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9813

Description

If there are some components inside hidden nested form that have validateWhenHidden, add this property to the Nested Form component itself, so during the parent's form validation it won't be skipped.

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

formio/core#229

How has this PR been tested?

Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

this.component.validateWhenHidden = true;
// Change original component as well, so it won't cause any custom logic to be continuously triggered
// because the original component does not have this property
this.originalComponent.validateWhenHidden = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that we should not mutate the component by adding a property. I would rather add a non-enumerable property using Object.defineProperty.

Object.defineProperty(component, 'validateWhenHidden', {
  value: true,
  writable: true,
  enumerable: false
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @alexandraRamanenka - we're going to go with a top down approach for nested forms. In other words, the nested form component will add the "validateWhenHidden" property to its definition, and child components will respect that parent property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants