Skip to content

[RTE-594] Omit fallback option getting pck certs when early/late ucode components are missing #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

[RTE-594] Omit fallback option getting pck certs when early/late ucode components are missing #821

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a0ec1f
Omit fallback option getting pck certs when early/late ucode componen…
raoulstrackx Oct 17, 2025
5846a69
Refactor to use `if let` instead of `match`
raoulstrackx Oct 18, 2025
a523d2b
Update comment
raoulstrackx Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions intel-sgx/dcap-artifact-retrieval/src/provisioning_client/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,20 +625,16 @@ pub trait ProvisioningClient {
// also try with highest microcode version of both components. We found cases where
// fetching the PCK Cert that exactly matched the TCB level, did not result in a PCK
// Cert for that level
const EARLY_UCODE_IDX: usize = 0;
const LATE_UCODE_IDX: usize = 1;
// Unfortunately the TCB Info does not populate the component type (e.g., curl -v -X GET
// "https://api.trustedservices.intel.com/sgx/certification/v4/tcb?fmspc=00906ED50000&tcbEvaluationDataNumber=20"
// ). We pick a default as backup, and ensure errors fetching these PckCerts are
// ignored.
let eary_ucode_idx = tcb_data.tcb_component_index(TcbComponent::EarlyMicrocodeUpdate).unwrap_or(EARLY_UCODE_IDX);
let late_ucode_idx = tcb_data.tcb_component_index(TcbComponent::LateMicrocodeUpdate).unwrap_or(LATE_UCODE_IDX);
let early_ucode = cpu_svn[eary_ucode_idx];
let late_ucode = cpu_svn[late_ucode_idx];
if early_ucode < late_ucode {
let mut cpu_svn = cpu_svn.clone();
cpu_svn[eary_ucode_idx] = late_ucode;
let _ign_err = get_and_collect(&mut pckcerts_map, &cpu_svn, pce_isvsvn);
let early_ucode_idx = tcb_data.tcb_component_index(TcbComponent::EarlyMicrocodeUpdate);
let late_ucode_idx = tcb_data.tcb_component_index(TcbComponent::LateMicrocodeUpdate);
if let (Some(early_ucode_idx), Some(late_ucode_idx)) = (early_ucode_idx, late_ucode_idx) {
let early_ucode = cpu_svn[early_ucode_idx];
let late_ucode = cpu_svn[late_ucode_idx];
if early_ucode < late_ucode {
let mut cpu_svn = cpu_svn.clone();
cpu_svn[early_ucode_idx] = late_ucode;
let _ign_err = get_and_collect(&mut pckcerts_map, &cpu_svn, pce_isvsvn);
}
}
}

Expand Down