Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SeisSol to package index #403

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

ashirrwad
Copy link
Member

Added the SeisSol package listed on Issue: fortran-lang/webpage#50 to the package index.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. While at first this looked like a C++ project with Fortran bindings, on closer look it seems to be a mixed C++ and Fortran project.

We've had some discussions in the past whether Fortran bindings to a foreign-language project would be appropriate for the index. While I think they are, I don't think we've reached a consensus about it.

@certik
Copy link
Member

certik commented May 6, 2022

I also thought this is a C++ project with legacy Fortran, but it seems it has physics stuff in Fortran and it is still developed in Fortran (see e.g. SeisSol/SeisSol#536), so I would say this package fits into our index.

(If it was just Fortran wrappers, then I would say we should have a category for Fortran wrappers to other packages.)

@certik certik merged commit 41dc622 into fortran-lang:master May 6, 2022
@ivan-pi
Copy link
Member

ivan-pi commented May 6, 2022

For the record, the developers have told me they would like to remove Fortran soon. See also the comment here: fortran-lang/webpage#50. If you look closer, they already have an issue to migrate the physics stuff from Fortran to C++: SeisSol/SeisSol#538.

@ashirrwad
Copy link
Member Author

As the package was still a part of checklist on fortran-lang/webpage#50 and the library and its documentation showed references to Fortran usability I figured it was still up for addition. While I did stick to the guide the criterias for package addition are a bit ambiguous to me as I am new to the language. If the package doesn't meet the requirements I will add a PR to revert these changes as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants