Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC’22: Port fortran-lang.org to Sphinx #414

Closed
wants to merge 286 commits into from

Conversation

henilp105
Copy link
Member

@henilp105 henilp105 commented Jul 24, 2022

This pr is to port the Existing site of fortran-lang.org to sphinx.
This GSoC’22 project is done by Henil Shalin Panchal under the Guidance of GSoC mentors Sebastian Ehlert @awvwgk and Rohit Goswami @HaoZeke .
https://summerofcode.withgoogle.com/programs/2022/projects/L28fukIz

Thanks and Regards,
Henil Shalin Panchal

@henilp105
Copy link
Member Author

Thanks sir, I will surely patch this.

Thanks and Regards,
Henil Shalin Panchal

@awvwgk
Copy link
Member

awvwgk commented Jul 27, 2022

The data files like contributors.json shouldn't be checked into git, if we are able to generate them in conf.py. Instead we should explicitly ignore them in .gitignore.

@henilp105
Copy link
Member Author

Sir, but they aren't made at the build time, they are generated by workflow (fortran_packages) by using cron .

@awvwgk
Copy link
Member

awvwgk commented Jul 27, 2022

Can we generate them in conf.py instead? This wouldn't require to continuously push new commits to the repository.

The step can be guarded to be done only if requested, to avoid refetching the data to frequently in local builds, while in CI the environment variable will be set accordingly:

if os.environ.get('SPHINX_GET_DATA', None) == 'True':
    ...

We than can put the build of the page itself on a cron job.

@henilp105
Copy link
Member Author

henilp105 commented Jul 27, 2022

We can surely do that sir, but that would lead to increase in the build time by 2.5 mins as this data fetching script takes about 2.5 mins to fetch data from github api. and in local builds the data is fetched directly from json files from repo by a get request .

@awvwgk
Copy link
Member

awvwgk commented Jul 27, 2022

We already have data files checked into the repository, so this should be okay to keep for the time being. Still it would be preferable to not have to check-in those data files in the first place, but we have to store them somewhere, of course.

@henilp105
Copy link
Member Author

Sure sir, I will be finding a balanced way out.

Thanks and Regards,
Henil Shalin Panchal

@awvwgk
Copy link
Member

awvwgk commented Aug 19, 2022

This has been resolved with the migration to the new repository (see #415)

@awvwgk awvwgk closed this Aug 19, 2022
@henilp105 henilp105 deleted the master branch April 22, 2023 15:23
@henilp105 henilp105 restored the master branch April 22, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants