Metapackage for NetCDF

[krystophny]

Apply once #1123 is merged. Docs in fortran-lang/fpm-docs#160

Besides NetCDF support and refactoring the way pkg-config is used from there and HDF5, there are modifications on the way flags are handled. Now all are converted from strings to arrays on the way. This was required because Intel Fortran dies on empty "-I" flags returned by pkg-config. In addition that allowed to avoid duplicate flags - a feature that could later be added more generally (there are a few also generated in other parts of the code, see fpm build --verbose) @perazz if you have time, please check if I use your split function correctly.

[krystophny]

... on hold for now, the tokenization of the flags still causes some issues.

[perazz]

tokenization of the flags

@krystophny I see you already tested using shlex. Behavior from Python shlex is the same as fortran-shlex.
Mind to please try using fortran-shlex 1.1.0 where I've implemented token joining?

[krystophny]

@perazz thanks! Yeah, my problem is that it should support

'-I/path/to/include -I /test -I"/path/to/include with spaces" -I "spaces here too" -L/path/to/lib -lmylib'

and split it into 6 parts and keep the spaces between flag and path as well as double quotes (and also single quotes if present)

['-I/path/to/include', '-I /test', '-I"/path/to/include with spaces"', '-I "spaces here too"', '-L/path/to/lib', '-lmylib']

Is this possible with shlex and/or some customization?

[perazz]

I see. So what we need is an option to retain the quotes from the shell lexer (that are typically removed, see i.e. this.). I guess the best place to do this is from within fortran-shlex

[perazz]

I have deployed a keep_quotes option in v1.2.0 that should do the job. Please keep me posted.

[krystophny]

Alright! A small fix is still needed in fortran-shlex - see perazz/fortran-shlex#6 . In addition, I split this PR now into three, so the order to merge is

1. Refactor: Move common functionality into fpm_meta_util #1122
2. Process command line args as arrays #1123 (let me know once you bumped the fortran-shlex version to fix it in fpm.toml)
3. Metapackage for NetCDF #1120
4. Metapackage for BLAS #1121

[krystophny]

Thanks a lot for the prompt review and merge, @perazz ! Now both, NetCDF and BLAS are finished. For BLAS I go in the search order of cmake: Apple Accelerate -> Intel MKL -> OpenBLAS -> Reference BLAS .

[perazz]

Thank you for this nice addition @krystophny!
I have only removed a couple unused variables from the test program.

LGTM otherwise.

[krystophny]

Great, thanks @perazz !