Fixes #2318 Events bookmarked from Featured Speakers are now visible in AboutFragment.

[raj10071997]

Fixes #2318

Changes: Before when the onResume() method was called in AboutFragment.java, it doesn't update the bookMarksListAdapter with the new data. Now call to the function getBookmarkedSessions() first checks the new data and then update the list for the bookMarksListAdapter.

[iamareebjamal]

IMO, this is a workaround and not a solution

[raj10071997]

@iamareebjamal Actually I thought of this solution because when we come back from SpeakerDetailsActivity.java, the onResume() method of AboutFragment.java is called which in turn calls the getBookmarkedSessions(). Now this method returns the previous list of sessions and not the updated one, so there must be a way to update it and that's why I thought of this solution.

[raj10071997]

@iamareebjamal Can you please tell in which cases the solution is failing so that I can make the changes?

[shivaraju07]

I tried this method. It works fine for me.

[iamareebjamal]

The thing is that we are using Realm, it should automatically update no matter if bound in onResume or onStart, the problem is in the reactivity and not the lifecycle. If we say that the bug is fixed by allowing this workaround, then it may pass several subtle bugs in the future

[raj10071997]

@iamareebjamal Ok. Then I'll try to think of something else.

[iamareebjamal]

@raj10071997 Status?

[raj10071997]

@iamareebjamal sorry for the late reply. The auto update of the objects in realm only happens when that object is a model object. I referred to this link - https://medium.com/@ffvanderlaan/realm-auto-updated-objects-what-you-need-to-know-b2d769d12d76. And LiveData only notifies active observers about updates. Also "session" is an object of LiveData which will only notify the observer only when it gets updated. So when onResume method is called, it will notify only when the session object is updated. And since it session is not a Model object of realm it will not be auto updated and will return the old list.

[iamareebjamal]

realmRepo.getBookMarkedSessions() these should be reactive and live and hence should be updated automatically

[raj10071997]

But without going inside the if condition how the sessions object will be updated because we are returning sessions object. I added this condition "numberOfBookmarkedSessions != realmRepo.getBookMarkedSessionsLength()" so that the body of the if condition will be executed only when there is change in the realm.

[raj10071997]

Actually I tried and changed the body of the if condition to this,

 if(sessions == null) {
      sessions = Transformations.map(RealmDataRepository.asLiveData(realmRepo.getBookMarkedSessions()),this::getSessionsList);
   }  

I changed this because realmRepo.getBookMarkedSessions() should be executed if the object is auto updated but still after changing the code to this sessions object returns the old list.

[iamareebjamal]

I would recommend that you actually try to get bookmarked sessions from RealmRepository and add a listener on them and check if you are getting change event or not. This will reveal the problem

[raj10071997]

Ok.

[raj10071997]

@srv-twry The changes you mentioned are the only changes that needed to be done?

[dr0pdb]

Yes, they are the only changes that i made.
The error you're getting is weird. Can you completely uninstall the application and reinstall it after making the above changes ?

[raj10071997]

I am still getting the same results. I also noticed one thing that when you install the app so you are basically logged out (now don't login) and then if you try to bookmark the events, the events don't get displayed at all in AboutFragment.java, doesn't matter how many events you bookmark. Are you getting the same results too when you install the app and you are logged out? I am using Android 7.0 Nougat (API 24).

[dr0pdb]

The above GIF that i uploaded has me logged out only.

[raj10071997]

Ok. I'll try to see why am I getting these errors. As I cleared the cache data and uninstalled the application and then installed it with your suggested changes. I have my development branch updated with the remote branch. And still I am getting these errors. I'll see why am I getting these errors and will notify you soon.