Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in robotic arm activity #2652

Merged

Conversation

rahul31124
Copy link
Contributor

@rahul31124 rahul31124 commented Mar 16, 2025

Crash Fix
The Robotic Arm screen was crashing due to a java.lang.NumberFormatException when the EditText view was empty and the "Done" button was pressed

Exception
java.lang.NumberFormatException: For input string: ""
at java.lang.Integer.parseInt(Integer.java:807)
at java.lang.Integer.valueOf(Integer.java:1128)
at io.pslab.activity.RoboticArmActivity$15.onEditorAction(RoboticArmActivity.java:436)
at android.widget.TextView.onEditorAction(TextView.java:7967)

Changes

Added validation to check if the EditText is empty before parsing the value.
If the input is empty, the previous valid value is restored.

Screenshots / Recordings

Before
Robotic_Arm_Before.webm
After
Robotic_Arm_After.webm

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Bug Fixes:

  • Fixes a NumberFormatException crash in the Robotic Arm activity when the degree input field is empty.

Copy link

sourcery-ai bot commented Mar 16, 2025

Reviewer's Guide by Sourcery

This pull request fixes a crash in the Robotic Arm activity that occurred when the app tried to parse an empty string to an integer. To fix this, the code was modified to validate the input from the EditText fields. If the input is empty, the code now restores the previous valid value.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added validation to prevent NumberFormatException when parsing empty EditText input.
  • Added a check to see if the EditText input is empty.
  • If the input is empty, the previous valid degree value is restored.
  • If the input is not empty, the degree value is parsed from the EditText input.
app/src/main/java/io/pslab/activity/RoboticArmActivity.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rahul31124 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider refactoring the duplicated code into a separate method to improve readability and maintainability.
  • The logic for restoring the previous degree when the input is empty could be simplified.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Mar 16, 2025

@AsCress AsCress added the Fix Solution to an existing issue in app label Mar 18, 2025
@AsCress AsCress self-requested a review March 18, 2025 12:54
@AsCress AsCress force-pushed the fix-crash-in-robotic-arm-activity branch from 2c464c1 to 445cf8c Compare March 18, 2025 13:02
@AsCress AsCress added the Status: Review Required Requested reviews from peers and maintainers label Mar 23, 2025
@marcnause marcnause self-requested a review March 30, 2025 15:12
Copy link
Contributor

@marcnause marcnause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested with Android 13 device.

@marcnause marcnause merged commit 01d6ed0 into fossasia:development Apr 2, 2025
4 checks passed
@marcnause marcnause removed the Status: Review Required Requested reviews from peers and maintainers label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants