docs: 2659 - Did translation to other languages #2660
Merged
+53
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request adds translations for new strings in the application to Arabic, Polish, Russian, and Sinhala. The translated strings include navigation items, color names, sensor-related terms, and plot descriptions. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ChehakTrehan - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you've added translations for new strings, but also duplicated
nav_documentationin the Arabic translation; please remove the duplicate. - Consider using a translation service or professional translator to ensure accuracy and natural-sounding translations.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
49
to
52
| <string name="control_item_1">مراقبة</string> | ||
| <string name="control_item_2">اقرأ</string> | ||
| <string name="control_item_3">المتقدمة</string> | ||
| <string name="nav_documentation">توثيق</string> |
There was a problem hiding this comment.
issue (bug_risk): Duplicated key 'nav_documentation' in Arabic resources
The Arabic resource file adds 'nav_documentation' twice with different translations, which may lead to unpredictable behavior at runtime. Consider consolidating these entries into a single entry with the intended translation.
|
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/14294942478/artifacts/2890502898 |
ChehakTrehan
changed the title
marcnause
added
the
Status: Review Required
This was referenced Apr 2, 2025
Closed
|
Hii @marcnause please review this PR |
marcnause
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did translation for the strings
Summary by Sourcery
Add translations for multiple languages, including new strings for navigation, color, sensor, and plot-related terms
New Features:
Enhancements:
Documentation: