Last message is completely visible in chat #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jogendra Please review! 😃 |
jogendra
suggested changes
Nov 6, 2018
| @@ -113,7 +113,7 @@ extension ChatViewController: UICollectionViewDelegateFlowLayout { | |||
| } else if message.actionType == ActionType.video_play.rawValue || message.actionType == ActionType.audio_play.rawValue { | |||
| return CGSize(width: view.frame.width, height: 158) | |||
| } | |||
| return CGSize(width: view.frame.width, height: estimatedFrame.height + 38) | |||
| return CGSize(width: view.frame.width, height: estimatedFrame.height + 60) | |||
There was a problem hiding this comment.
Set edge inset instead of changing the height of the cell.
There was a problem hiding this comment.
I tried various combinations of edge insets but none of them seemed to work out. It would be a great help if you could suggest any value set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
Changes: Changed the height of CGSize from 38 to 60. Now, the last message in chat can be seen completely
Screenshots for the change:
GIF -
.