Feat: Made Link in Chat Clickable #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#note some time you may not able to click link because of content view height issue solved in this PR #512 |
jogendra
suggested changes
Feb 21, 2019
There was a problem hiding this comment.
@raghavbabbar I can't able to open the link in the chat. Make sure it works every time.
@jogendra this was due to issue in #512 . Now i have merged master in this branch. please take pull before testing it . thanks |
jogendra
approved these changes
Feb 28, 2019
|
I would suggest creating another PR because there seems to be a lot of unwanted code which would cause issues if we plan to revert this PR at any point in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: #517
Changes: made link in chat view clickable And opened them in browser.