fix(api): Handle empty PATCH request body #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change addresses an issue where sending a PATCH request with an empty JSON body ({}) to the /licenses/{shortname} endpoint would cause all fields of the corresponding license to be set to NULL in the database. This was happening because the LicenseUpdateDTO struct was being populated with nil values, which GORM then interpreted as an instruction to nullify the database columns.
Handle Empty Request Body: The UpdateLicense function in pkg/api/licenses.go now checks if the request body is empty. If it is, the function returns the existing data without making any changes, preventing accidental data loss.
Selective Field Updates: The function now uses a map to ensure that only the fields explicitly provided in the PATCH request are updated. This aligns with the expected behavior of a PATCH request and prevents unintended side effects.
Fixes #148
Submitter Checklist
[x] Includes tests (if there is a feature changed/added)
[ ] Includes docs ( if changes are user facing)
[x] I have tested my changes locally.
References
N/A