Skip to content

Conversation

@Abhishek-TAMU
Copy link
Contributor

@Abhishek-TAMU Abhishek-TAMU commented Dec 5, 2025

Error also seen when DPP is run for FP16 Granite model using RAG --programs *:0,>=8192 to test chunked prefill feature.
From @Ssukriti 's knowledge transfer got to know that the issue occurs when prompt_list in __prepare_input function is empty for any shape. Hence Value error is raised to trigger this and continue finding the prompt for that program.

It successfully runs all 14 programs.

cc: @JRosenkranz

@Ssukriti
Copy link
Contributor

Ssukriti commented Dec 5, 2025

Thanks Abhishek for the fix and the logs!

For Josh - The fix basically just raises an exception which is caught in drive_paged_programs and the loop continues with the next prompt shape for the program.

LGTM

@Ssukriti
Copy link
Contributor

Ssukriti commented Dec 5, 2025

bot:test
TEST_FILE=test_scripts.py

@Ssukriti Ssukriti self-requested a review December 5, 2025 20:40
@Ssukriti
Copy link
Contributor

Ssukriti commented Dec 5, 2025

bot:test
TEST_FILE=test_scripts.py

@Ssukriti Ssukriti merged commit fc3a30f into foundation-model-stack:main Dec 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants