Skip to content

Add regression tests for get_latest and get_oldest functions #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weiji14 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add regression tests for get_latest and get_oldest functions #110

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0919fa
Fix bug with repeated checkpoint path
weiji14 Aug 15, 2024
4a2b4b8
Remove os.path.join in get_oldest function also
weiji14 Aug 27, 2024
f082164
Add unit tests for get_latest and get_oldest functions
weiji14 Aug 27, 2024
cf39fc7
Run os.path.getctime on full path instead of just filename
weiji14 Sep 3, 2024
0ea1dc5
Merge branch 'main' into repeated-ckpt-path
weiji14 Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions fms_fsdp/utils/checkpointing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,8 @@ def get_latest(targdir, qualifier=lambda x: True):
If directory is empty or nonexistent or no items qualify, return None."""
if os.path.exists(targdir) and len(os.listdir(targdir)) > 0:
latest = max(
[
os.path.join(targdir, x)
for x in os.listdir(targdir)
if qualifier(os.path.join(targdir, x))
],
key=lambda path: int(path.split("/")[-1].split("_")[1]),
[x for x in os.listdir(targdir) if qualifier(os.path.join(targdir, x))],
key=lambda path: int(path.split("_")[1]),
Copy link
Contributor

@nairbv nairbv Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the same issue below with get_oldest ?

maybe we could add a unit test?

Copy link
Author

@weiji14 weiji14 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, removed os.path.join in the get_oldest function in commit 4a2b4b8, and added unit tests in commit f082164.

Copy link
Contributor

@nairbv nairbv Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better, though now the ctime key fails in get_oldest

Copy link
Author

@weiji14 weiji14 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, have pushed a fix, can you run the tests again to see if it works?

)
return os.path.join(targdir, latest)
return None
Expand Down