Final singlefile checkpoint saves one folder up #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Davis Wertheimer <[email protected]>
daviswer
force-pushed
the
ckp-path-handling
branch
from
45cc260 to
292b459
Compare
Contributor
|
@daviswer one convention I have been using is:
would using this convention fit the need here as well? if so, we can use this convention. |
Collaborator
Author
|
oh yeah that's a good idea, I'll set that up |
Signed-off-by: Davis Wertheimer <[email protected]>
Contributor
|
@daviswer is the final pth file a single file or multiple? |
Contributor
|
I think we should make it This will make it easier for future consumption/conversion, e.g. https://github.com/huggingface/transformers/blob/main/src/transformers/models/llama/convert_llama_weights_to_hf.py#L231 to summarize, our folders should look like: |
Collaborator
Author
|
Sure I can do that. It is always a single file. |
Signed-off-by: Davis Wertheimer <[email protected]>
lchu6
approved these changes
Jan 14, 2025
daviswer
added a commit
that referenced
this pull request
Jun 3, 2025
* make mamba * add quick debug * add quick debug * revert debug verbosity * Learning rate scheduler changed (Constant) * Add AutoHandler * Add Auto cfg option for AutoHAndler * Len gets called before open * path/filepath typo fix * Partitioning fix from mup-search * Cosine 0.01 decay * Warmup interval change * Schedule change * Constant schedule * LR schedule change (cool down and constant lr) * Update dataset_utils.py Added a check for length of doc * LR schedule change (Warmup + constant) * Update dataset_utils.py * Cosine schedule * For constant lr 1.5e5 * Schedule change * Schedule change * Final singlefile checkpoint saves one folder up (#127) * Final singlefile checkpoint saves one folder up Signed-off-by: Davis Wertheimer <[email protected]> * save file under new pth subfolder Signed-off-by: Davis Wertheimer <[email protected]> * Repath for easier consumption/conversion Signed-off-by: Davis Wertheimer <[email protected]> --------- Signed-off-by: Davis Wertheimer <[email protected]> * Added cool down * length of doc check * splitstrip cols and pass to fhandler * fhandler col_names support * Warmup for annealing * Debugging * Debugging II * Empty shard check * Added constant lr schedule with warmup * added print for lenght of doc * added print for lenght of doc II * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * Adding print for debug * Revert "Pulled from data-fixes branch" This reverts commit ac5194b, reversing changes made to 1b50708. reverting changes * Revert all changes made after March 6 (before merge) * Revert all changes made after March 6 (before merge) * removed print --------- Signed-off-by: Davis Wertheimer <[email protected]> Co-authored-by: Linsong Chu <[email protected]> Co-authored-by: divykum2 <[email protected]> Co-authored-by: divya-kumari32 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #126
Adjusts the save location of final single-file checkpoint to be one folder up (directly in the specified ckp directory, rather than under the 'checkpoints' subfolder). That way the dataloader checkpointer only has to deal with distributed checkpoint folders.