-
Notifications
You must be signed in to change notification settings - Fork 17
chore: Update torch requirement from <2.6,>=2.2.0 to >=2.2.0,<2.8 #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update torch requirement from <2.6,>=2.2.0 to >=2.2.0,<2.8 #100
Conversation
Updates the requirements on [torch](https://github.com/pytorch/pytorch) to permit the latest version. - [Release notes](https://github.com/pytorch/pytorch/releases) - [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md) - [Commits](pytorch/pytorch@v2.2.0...v2.7.0) --- updated-dependencies: - dependency-name: torch dependency-version: 2.7.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
|
@IqbalSaraf plz run unit tests with PyTorch 2.6 and 2.7 to verify this PR. |
|
For PyTorch=2.6. In file dq.py, need to update line 252 from "test_dataset = torch.load(pt_files[0])" to "test_dataset = torch.load(pt_files[0], weights_only=False)". Additionally, I used transformers version 4.47.1. Note: using latest version of transformers 4.51.3, model is returned as tuple not as dictionary. In order to use latest version of transformers, we may need to update our code. |
|
Additionally, In dq.py, need to wrap evaluator with "with patch_torch_bmm(qcfg): " at line 256 and 262 during evaluation so that evaluator uses the bmms. |
|
PyTorch2.7 verification of fms_mo is completed. The following functionalities (DQ, FP8, GPTQ, PTQ, AIU conversion) were verified with PyTorch2.7. The results (perplexity/ accuracy) matches as expected. PTQ had an error which is unrelated to PyTorch version. |
Signed-off-by: chichun-charlie-liu <[email protected]>
Signed-off-by: chichun-charlie-liu <[email protected]>
BrandonGroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Ignoring the github action pylint. No idea why that is being flagged... Charlie has done a local pylint and it isn't showing up, making me believe it's a false positive.
Updates the requirements on torch to permit the latest version.
Release notes
Sourced from torch's releases.
... (truncated)
Changelog
Sourced from torch's changelog.
... (truncated)
Commits
1341794Gracefully handle optree less than minimum version, part 2 (#151323)0739127Gracefully handle optree less than minimum version (#150977)0c236f3Update triton wheel build, setuptools pin (#150953)c7ff78dFix inplacing with multiple, fused uses (#150892)894909aRevert "[CUDA] Only use vec128 if CUDA version is newer than 12.8" (#150855)ef2b139[Manylinux 2.28] Correct Linux aarch64 cuda binaries wheel name (#150820)3f236f1[CUDA] Only use vec128 if CUDA version is newer than 12.8 (#150818)35f1e76Reland of "[ROCm] change preferred blas lib defaults (#150249)"" (#150707)a6321d6Revert "Dont exclude constant_pad_nd in prologue fusion" (#150699)1cc51c6[CUDA][avgpool2d] Fix backward launch bounds again forsm100,sm120(#150...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)