fix: FP8 TP fixes #176
Merged
fix: FP8 TP fixes #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoni Viros i Martin <[email protected]>
ani300
requested review from
BrandonGroth,
andrea-fasoli,
chichun-charlie-liu,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
Contributor
Author
|
We can close #174 as this one is a better fix |
andrea-fasoli
approved these changes
Aug 6, 2025
Collaborator
andrea-fasoli
left a comment
andrea-fasoli
left a comment
There was a problem hiding this comment.
Fix sharding dimension. Looks good
joerunde
added a commit
to vllm-project/vllm-spyre
that referenced
this pull request
Aug 8, 2025
# Description The general idea is that the FP8 model can be used in all SB/CB scenarios. This requires unreleased changes from fms and fms-mo in order to work: - foundation-model-stack/foundation-model-stack#457 - foundation-model-stack/fms-model-optimizer#176 While the tests may pass on cpu, they will continue to fail on spyre ## Related Issues Also addresses: #356 --------- Signed-off-by: Prashant Gupta <[email protected]> Signed-off-by: Joe Runde <[email protected]> Co-authored-by: Joe Runde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This will not work without a PR in FMS (foundation-model-stack/foundation-model-stack#457)
Related issues or PRs
How to verify the PR
Was the PR tested
Checklist for passing CI/CD:
git commit -signoffor equivalenttox -e fixtox -e linttox -e spellchecktox -e unitNote: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.