Small updates to the docs #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hickeyma
requested review from
andrea-fasoli,
chichun-charlie-liu,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
hickeyma
force-pushed
the
doc/readme-update
branch
from
a58c789 to
61f5d7e
Compare
chichun-charlie-liu
requested changes
Dec 18, 2024
Collaborator
chichun-charlie-liu
left a comment
chichun-charlie-liu
left a comment
There was a problem hiding this comment.
minor changes, plz see comments
Signed-off-by: Martin Hickey <[email protected]>
hickeyma
force-pushed
the
doc/readme-update
branch
from
61f5d7e to
ed79ecd
Compare
Review comments: - foundation-model-stack#40 (review) Signed-off-by: Martin Hickey <[email protected]>
Signed-off-by: Martin Hickey <[email protected]>
Collaborator
Author
|
Thanks @chichun-charlie-liu for the review and feedback. Comments are updated and also added the release install steps to the README. Ready for review again. |
chichun-charlie-liu
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.