-
Notifications
You must be signed in to change notification settings - Fork 17
Add logging and tests for run_quant.py #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging and tests for run_quant.py #44
Conversation
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
BrandonGroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some testing comments:
- Can we put the entire run_quant test in its own tests/run_quant directory?
- We should be making fixtures of any testing inputs like MODEL_ARGS, etc.. There likely will be a time where multiple different args will be accepted, so its good to make them lists and parameterize them (even if single-valued for now). This registers them in Pytest and makes it easier to see errors, rerun single failed test cases, etc.. See the models/conftest.py examples.
Signed-off-by: Thara Palanivel <[email protected]>
@BrandonGroth Typically the same dir structure as |
1e7856e
into
foundation-model-stack:main
Description of the change
Add logging and tests for
run_quant.pyRelated issue number
How to verify the PR
All unit tests pass
Was the PR tested