feat: added granite support; fixed adapters to ignore model_config #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JOSHUA ROSENKRANZ <[email protected]>
JRosenkranz
requested review from
andrea-fasoli,
chichun-charlie-liu,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Andrea Fasoli <[email protected]>
andrea-fasoli
approved these changes
Jan 22, 2025
Signed-off-by: chichun-charlie-liu <[email protected]>
tharapalanivel
requested changes
Jan 30, 2025
Signed-off-by: chichun-charlie-liu <[email protected]>
tharapalanivel
changed the title
tharapalanivel
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Added support for gptq granite as currently the gptq adapter does not support granite. Fixed bug where if model_config is passed to adapter, it would raise an exception.
Related issue number
NA
How to verify the PR
Was the PR tested