Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getcontractcreation binding #24

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Jan 1, 2024

This PR adds binding for getcontractcreation method which returns contract deployer and creation tx.

I will need this to complete #6344 foundry issue.

I have only added binding and support for fetching data for single contract but Etherscan supports fetching those for up to 5 contracts at a time. Considering such small restriction, does it make sense to implement binding for multi-contract requests too?

@klkvr klkvr requested review from DaniPopes and Evalir as code owners January 1, 2024 19:20
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just smol nits re: docs. tests look good

I think it's fine to only have bindings for 1 contract at a time. We can always add multi contract binds later

src/contract.rs Show resolved Hide resolved
src/contract.rs Show resolved Hide resolved
src/contract.rs Outdated Show resolved Hide resolved
@klkvr klkvr requested a review from Evalir January 4, 2024 14:06
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u sir

@Evalir Evalir merged commit 478df0f into foundry-rs:main Jan 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants