Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: chain_id param in etherscan query req #36

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

yash-atreya
Copy link
Member

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, do all the other endpoints now also support the chain id or just verification?

I think this only covers verification:

https://docs.etherscan.io/contract-verification/multichain-verification

so I think we should limit this pr to verify

@yash-atreya
Copy link
Member Author

hmm, do all the other endpoints now also support the chain id or just verification?

I think this only covers verification:

https://docs.etherscan.io/contract-verification/multichain-verification

so I think we should limit this pr to verify

I could just append chain_id to other in verify related methods in https://github.com/foundry-rs/block-explorers/blob/main/src/verify.rs

@mattsse
Copy link
Member

mattsse commented Mar 29, 2024

we can add this as optional arg to the verify args

#[serde(rename = "chainId", skip_serializing_if = "Option::is_none")]
    pub chain_id: Option<bool>,

that should take care of it

@yash-atreya yash-atreya requested a review from mattsse March 29, 2024 14:12
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!
a few more nits

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@yash-atreya yash-atreya requested a review from mattsse March 29, 2024 18:01
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I believe this should do it

@mattsse mattsse merged commit b669d44 into foundry-rs:main Mar 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants