-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: chain_id param in etherscan query req #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, do all the other endpoints now also support the chain id or just verification?
I think this only covers verification:
https://docs.etherscan.io/contract-verification/multichain-verification
so I think we should limit this pr to verify
I could just append |
we can add this as optional arg to the verify args #[serde(rename = "chainId", skip_serializing_if = "Option::is_none")]
pub chain_id: Option<bool>, that should take care of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
a few more nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I believe this should do it
Required for foundry-rs/foundry#7485