Bug: Etherscan cache is constantly invalidated #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Apr 15, 2024
Good point, I've documented the fields and the expiry logic |
mattsse
approved these changes
Apr 15, 2024
zerosnacks
added a commit
to foundry-rs/foundry
that referenced
this pull request
Apr 15, 2024
mattsse
pushed a commit
to foundry-rs/foundry
that referenced
this pull request
Apr 15, 2024
bump foundry-block-explorers version to include foundry-rs/block-explorers#40
2 tasks
This was referenced Jun 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: foundry-rs/foundry#6792
Due to a small logical error and a missing smoke test the Etherscan cache was constantly being invalidated.
On a large codebase with 197 tests, without this optimization: foundry-rs/foundry#7606
Comparison: