chore(blob-explorers): accomodate new blobscan API changes
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Dec 9, 2024
Comment on lines
-166
to
-169
| /// Block hash. | ||
| pub hash: B256, | ||
| /// Block timestamp. | ||
| pub timestamp: chrono::DateTime<chrono::offset::Utc>, |
There was a problem hiding this comment.
aren't those still available?
feels odd that those are removed
There was a problem hiding this comment.
These fields are present when fetching a block, for which BlockResponse<T> has these fields—BlockInfo doesn't need them as it corresponds to a transaction response (see /blocks/{id} vs /transactions/{id}).
klkvr
requested changes
Dec 9, 2024
klkvr
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blobscan had some more API changes. They added a few things:
DataStorageReferencesfields to bestorageandurl.This aligns the new responses to the new format, and another tx test. See their API docs. Although I saw #66 open, the behavior implemented in that PR doesn't seem up to date anymore.