Skip to content

replaced default with calculate #10236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Rimeeeeee
Copy link
Contributor

replaced default with calculate_transaction_root() and calculate_receipt_root() in anvil_src_eth_backend_mem_mod.rs

@Rimeeeeee
Copy link
Contributor Author

@mattsse pls check this

@zerosnacks
Copy link
Member

Hi @Rimeeeeee would you mind undoing the formatting changes?

Note in https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md#resolving-an-issue we are using the nightly versions of fmt and clippy

cargo +nightly fmt -- --check

@Rimeeeeee
Copy link
Contributor Author

Hi @Rimeeeeee would you mind undoing the formatting changes?

Note in https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md#resolving-an-issue we are using the nightly versions of fmt and clippy

cargo +nightly fmt -- --check

Apology, took care of it :)

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to undo the extra ; here :)

getting there

@Rimeeeeee
Copy link
Contributor Author

@mattsse if used receipts_root: calculate_receipt_root(&receipts) the following error is shown:

the trait bound Receipt<alloy_rpc_types::Log>: Eip2718EncodableReceipt is not satisfied
the trait Eip2718EncodableReceipt is implemented for &'a T
required for ReceiptWithBloom<Receipt<alloy_rpc_types::Log>> to implement `Encodable2718`rustcClick for full compiler diagnostic
mod.rs(1642, 36): required by a bound introduced by this call
proofs.rs(51, 8): required by a bound in calculate_receipt_root

@Rimeeeeee Rimeeeeee requested a review from mattsse April 3, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants