Skip to content

migrate: anvil to revm 21 #10361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Apr 29, 2025
Merged

migrate: anvil to revm 21 #10361

merged 27 commits into from
Apr 29, 2025

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Apr 24, 2025 •
edited
Loading

Motivation

Closes #10356

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya changed the base branch from master to zerosnacks/revm-bump-2 April 24, 2025 07:36
@jenpaff jenpaff moved this to In Progress in Foundry Apr 28, 2025
@yash-atreya yash-atreya mentioned this pull request Apr 29, 2025
Merged
3 tasks
@yash-atreya
feat(anvil): op support revm 21 (#10407)
1afa5a2 
* enable OpHardforks in NodeConfig

* feat: add is_optimism flag to foundry_evm::Env

* feat(`anvil`): set is_optimism in Backend

* feat(`anvil`): introducing EvmContext enum holding Eth and Op variants.

* adds OpEnv to foundry_evm_core

* feat: EitherEvm

* impl Evm for EitherEvm

* integrate EitherEvm into RPC and executor

*Map OpHaltReason and OpTransactionError

* rm old evm helpers

* feat(`foundry_evm`): add deposit tx parts field to Env

* fix(`anvil`): set deposit tx parts in tx executor and backend.inspect_tx

* nit
@zerosnacks zerosnacks self-requested a review April 29, 2025 08:41
zerosnacks
zerosnacks approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

The use of alloy-evm / alloy-op-evm makes a lot of sense

My hope is we can also use it for Foundry given the modifications we require and access patterns we have

@yash-atreya yash-atreya marked this pull request as ready for review April 29, 2025 09:48
@yash-atreya yash-atreya requested a review from DaniPopes as a code owner April 29, 2025 09:48
@yash-atreya yash-atreya marked this pull request as draft April 29, 2025 09:48
@yash-atreya yash-atreya marked this pull request as ready for review April 29, 2025 12:34
@yash-atreya yash-atreya merged commit 100f72c into zerosnacks/revm-bump-2 Apr 29, 2025
7 of 22 checks passed
@yash-atreya yash-atreya deleted the yash/anvil-revm-21 branch April 29, 2025 13:05
@github-project-automation github-project-automation bot moved this from In Progress to Done in Foundry Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate anvil to revm 21
2 participants
@yash-atreya @zerosnacks