-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(hardfork
): support EIP-7907: increase initcode and contract code size limit
#10932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minors nits
Thanks! |
#[serde(skip)] | ||
pub ignore_eip_3860: bool, | ||
pub ignore_initcode_size: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zerosnacks @DaniPopes are you okay with changing the default here? Shouldn't be any breaking changes from cli usage due to this
Motivation
Closes #10624
EIP-7907 is now SFI'd for Osaka.
Solution
These code limits are lower and currently pending as a PR, but have been agreed upon in the latest ACDE.
forge build --sizes --evm-version osaka
can be used to test these changes andforge build --sizes --evm-version prauge
for regression testing.PR Checklist
--help
output to document--ignore-initcode-size
instead of--ignore-eip-3860
. Keep 3860 flag for backwards compatibility--ignore-initcode-size
to forge build docs