Skip to content

refactor: extract inline config from lint #11620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 13, 2025
Merged

refactor: extract inline config from lint #11620

merged 7 commits into from
Sep 13, 2025

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 11, 2025 •
edited
Loading

Extracting inline config changes from #10907, which also affect forge lint.

  • make inline config generic to support forge fmt
  • refactor to use spans and BytePos, making it clearer what the "usize"s actually mean
  • parse inline config in forge lint only once per file, using AST. this makes HIR implementation redundant, and actually makes it work (see diff in stderr file)
  • support yul statements in disable-next-item
  • remove loose since we don't use weird heuristics anymore

Blocked on #11563.

@DaniPopes
bless
dbe4182
@DaniPopes
feat: remove loose
1e15285 
Not needed anymore, we actually look at the next AST item instead of
weird heuristics that required it.
@DaniPopes DaniPopes marked this pull request as draft September 11, 2025 15:06
@DaniPopes DaniPopes marked this pull request as ready for review September 12, 2025 02:41
@DaniPopes DaniPopes self-assigned this Sep 12, 2025
0xrusowsky
0xrusowsky previously approved these changes Sep 12, 2025
View reviewed changes
@0xrusowsky
Copy link
Contributor

looks like there are some merge conflicts with the cmnt gatherer

@DaniPopes DaniPopes merged commit 6d7b3d0 into master Sep 13, 2025
25 checks passed
@DaniPopes DaniPopes deleted the dani/inline-config-generic branch September 13, 2025 01:57
@github-project-automation github-project-automation bot moved this to Done in Foundry Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xrusowsky 0xrusowsky 0xrusowsky approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees

@DaniPopes DaniPopes

Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @0xrusowsky