Add cast command to convert beacon payload to execution payload b2e-payload
#11629
Conversation
|
Have a couple of observations/questions @mattsse @shekhirin @jenpaff @zerosnacks, with this simple draft :
|
There was a problem hiding this comment.
good start, some suggestions, ideas
Right now I extract the payload from the example json given this path message.body.execution_payload, but I guess there are more beacon block json formats, depending on the api providers, do we want to support a couple ?
yep we could introduce an untagged enum
| // Get input beacon block data | ||
| let beacon_block = fs::read_to_string(&self.json_file) | ||
| .map_err(|e| eyre!("Failed to read JSON file '{}': {}", self.json_file.display(), e))?; |
There was a problem hiding this comment.
I think we also want this to support piped inputs or maybe even fetch the beacon block directly
but def piped input so you can do curl ... | cast b2e
| fn format_as_json_rpc(execution_payload: ExecutionPayload) -> Result<String> { | ||
| // TODO: check if we used this format and this method engine version | ||
| let json_rpc_request = serde_json::json!({ | ||
| "jsonrpc": "2.0", | ||
| "method": "engine_newPayloadV3", | ||
| "params": [execution_payload], | ||
| "id": 1 | ||
| }); |
There was a problem hiding this comment.
we def need some serde tests for this as well because converting payload variants totally sucks 👍
| let beacon_json: serde_json::Value = serde_json::from_str(beacon_block) | ||
| .map_err(|e| eyre!("Failed to parse beacon block JSON: {}", e))?; | ||
|
|
||
| // early detection if the format is not correct | ||
| if beacon_json | ||
| .get("message") | ||
| .and_then(|m| m.get("body")) | ||
| .and_then(|b| b.get("execution_payload")) | ||
| .is_none() | ||
| { | ||
| return Err(eyre!("Invalid beacon block format: missing 'message' field")); |
There was a problem hiding this comment.
could we add this to alloy as well, so that we dont need to do this manually?
| // TODO: check if we used this format and this method engine version | ||
| let json_rpc_request = serde_json::json!({ | ||
| "jsonrpc": "2.0", | ||
| "method": "engine_newPayloadV3", |
There was a problem hiding this comment.
for this wee need some --version argument as well
and we need to do some additional work here, because these endpoint take additional args:
| // TODO: check if we used this format and this method engine version | ||
| let json_rpc_request = serde_json::json!({ | ||
| "jsonrpc": "2.0", | ||
| "method": "engine_newPayloadV3", |
There was a problem hiding this comment.
let's either not do this conversion to Engine API -compatible request format at all, or do it optionally with an argument. The motivation to just have the execution payload in output is to be able to pipe this into reth-bench send-payload that accepts and RPC block.
Motivation
Closes #11603.
Solution
Add sub-command
b2e-payloadto convert execution payload from beacon block to rpc execution payload.e.g.:
File downloaded from these instructions :
PR Checklist