Skip to content

feat: add support for 7594 blobs to anvil #12238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

feat: add support for 7594 blobs to anvil #12238

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5dc5488
feat: add support for 7594 blobs to anvil
stevencartavia Oct 22, 2025
11843ad
Merge branch 'master' into support-for-7594-anvil
grandizzy Oct 22, 2025
0ae15a2
comments
stevencartavia Oct 22, 2025
5fe60e7
Merge branch 'master' into support-for-7594-anvil
stevencartavia Oct 22, 2025
1145bf5
Merge branch 'support-for-7594-anvil' of https://github.com/stevencar…
stevencartavia Oct 22, 2025
4fab009
updates
stevencartavia Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 106 additions & 35 deletions crates/anvil/core/src/eth/transaction/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,16 @@ use alloy_consensus::{
},
};

use alloy_eips::eip2718::{Decodable2718, Eip2718Error, Encodable2718};
use alloy_eips::{
eip2718::{Decodable2718, Eip2718Error, Encodable2718},
eip7594::BlobTransactionSidecarVariant,
};
use alloy_network::{AnyReceiptEnvelope, AnyRpcTransaction, AnyTransactionReceipt, AnyTxEnvelope};
use alloy_primitives::{Address, B256, Bloom, Bytes, Signature, TxHash, TxKind, U64, U256};
use alloy_rlp::{Decodable, Encodable, Header};
use alloy_rpc_types::{
AccessList, ConversionError, Transaction as RpcTransaction, TransactionReceipt,
request::TransactionRequest, trace::otterscan::OtsReceipt,
AccessList, ConversionError, TransactionReceipt, request::TransactionRequest,
trace::otterscan::OtsReceipt,
};
use alloy_serde::{OtherFields, WithOtherFields};
use bytes::BufMut;
Expand All @@ -28,6 +31,31 @@ use revm::{context::TxEnv, interpreter::InstructionResult};
use serde::{Deserialize, Serialize};
use std::ops::{Deref, Mul};

/// Extension trait for `BlobTransactionSidecarVariant` to provide convenient blob access
pub trait BlobTransactionSidecarVariantExt {
/// Get a reference to the blobs
fn blobs(&self) -> &[alloy_consensus::Blob];

/// Consume self and return the blobs
fn into_blobs(self) -> Vec<alloy_consensus::Blob>;
Copy link
Member

@mattsse mattsse Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant adding this natively to alloy by sending a pr there :)

}

impl BlobTransactionSidecarVariantExt for BlobTransactionSidecarVariant {
fn blobs(&self) -> &[alloy_consensus::Blob] {
match self {
Self::Eip4844(sidecar) => &sidecar.blobs,
Self::Eip7594(sidecar) => &sidecar.blobs,
}
}

fn into_blobs(self) -> Vec<alloy_consensus::Blob> {
match self {
Self::Eip4844(sidecar) => sidecar.blobs,
Self::Eip7594(sidecar) => sidecar.blobs,
}
}
}

/// Converts a [TransactionRequest] into a [TypedTransactionRequest].
/// Should be removed once the call builder abstraction for providers is in place.
pub fn transaction_request_to_typed(
Expand Down Expand Up @@ -166,7 +194,10 @@ pub fn transaction_request_to_typed(

if let Some(sidecar) = sidecar {
Some(TypedTransactionRequest::EIP4844(TxEip4844Variant::TxEip4844WithSidecar(
TxEip4844WithSidecar::from_tx_and_sidecar(tx, sidecar),
TxEip4844WithSidecar::from_tx_and_sidecar(
tx,
BlobTransactionSidecarVariant::Eip4844(sidecar),
),
)))
} else {
Some(TypedTransactionRequest::EIP4844(TxEip4844Variant::TxEip4844(tx)))
Expand All @@ -188,7 +219,7 @@ pub enum TypedTransactionRequest {
EIP2930(TxEip2930),
EIP1559(TxEip1559),
EIP7702(TxEip7702),
EIP4844(TxEip4844Variant),
EIP4844(TxEip4844Variant<BlobTransactionSidecarVariant>),
Deposit(TxDeposit),
}

Expand Down Expand Up @@ -273,7 +304,7 @@ impl Deref for MaybeImpersonatedTransaction {
}
}

impl From<MaybeImpersonatedTransaction> for RpcTransaction {
impl From<MaybeImpersonatedTransaction> for alloy_rpc_types::Transaction<TypedTransaction> {
fn from(value: MaybeImpersonatedTransaction) -> Self {
let hash = value.hash();
let sender = value.recover().unwrap_or_default();
Expand All @@ -285,69 +316,63 @@ pub fn to_alloy_transaction_with_hash_and_sender(
transaction: TypedTransaction,
hash: B256,
from: Address,
) -> RpcTransaction {
) -> alloy_rpc_types::Transaction<TypedTransaction> {
match transaction {
TypedTransaction::Legacy(t) => {
let (tx, sig, _) = t.into_parts();
RpcTransaction {
alloy_rpc_types::Transaction {
block_hash: None,
block_number: None,
transaction_index: None,
effective_gas_price: None,
inner: Recovered::new_unchecked(
TxEnvelope::Legacy(Signed::new_unchecked(tx, sig, hash)),
TypedTransaction::Legacy(Signed::new_unchecked(tx, sig, hash)),
from,
),
}
}
TypedTransaction::EIP2930(t) => {
let (tx, sig, _) = t.into_parts();
RpcTransaction {
alloy_rpc_types::Transaction {
block_hash: None,
block_number: None,
transaction_index: None,
effective_gas_price: None,
inner: Recovered::new_unchecked(
TxEnvelope::Eip2930(Signed::new_unchecked(tx, sig, hash)),
TypedTransaction::EIP2930(Signed::new_unchecked(tx, sig, hash)),
from,
),
}
}
TypedTransaction::EIP1559(t) => {
let (tx, sig, _) = t.into_parts();
RpcTransaction {
block_hash: None,
block_number: None,
transaction_index: None,
effective_gas_price: None,
inner: Recovered::new_unchecked(
TxEnvelope::Eip1559(Signed::new_unchecked(tx, sig, hash)),
from,
),
}
}
TypedTransaction::EIP4844(t) => {
let (tx, sig, _) = t.into_parts();
RpcTransaction {
alloy_rpc_types::Transaction {
block_hash: None,
block_number: None,
transaction_index: None,
effective_gas_price: None,
inner: Recovered::new_unchecked(
TxEnvelope::Eip4844(Signed::new_unchecked(tx, sig, hash)),
TypedTransaction::EIP1559(Signed::new_unchecked(tx, sig, hash)),
from,
),
}
}
TypedTransaction::EIP4844(t) => alloy_rpc_types::Transaction {
block_hash: None,
block_number: None,
transaction_index: None,
effective_gas_price: None,
inner: Recovered::new_unchecked(TypedTransaction::EIP4844(t), from),
},
TypedTransaction::EIP7702(t) => {
let (tx, sig, _) = t.into_parts();
RpcTransaction {
alloy_rpc_types::Transaction {
block_hash: None,
block_number: None,
transaction_index: None,
effective_gas_price: None,
inner: Recovered::new_unchecked(
TxEnvelope::Eip7702(Signed::new_unchecked(tx, sig, hash)),
TypedTransaction::EIP7702(Signed::new_unchecked(tx, sig, hash)),
from,
),
}
Expand Down Expand Up @@ -609,7 +634,7 @@ pub enum TypedTransaction {
/// EIP-1559 transaction
EIP1559(Signed<TxEip1559>),
/// EIP-4844 transaction
EIP4844(Signed<TxEip4844Variant>),
EIP4844(Signed<TxEip4844Variant<BlobTransactionSidecarVariant>>),
/// EIP-7702 transaction
EIP7702(Signed<TxEip7702>),
/// op-stack deposit transaction
Expand All @@ -627,7 +652,23 @@ impl TryFrom<AnyRpcTransaction> for TypedTransaction {
TxEnvelope::Legacy(tx) => Ok(Self::Legacy(tx)),
TxEnvelope::Eip2930(tx) => Ok(Self::EIP2930(tx)),
TxEnvelope::Eip1559(tx) => Ok(Self::EIP1559(tx)),
TxEnvelope::Eip4844(tx) => Ok(Self::EIP4844(tx)),
TxEnvelope::Eip4844(tx) => {
// Convert from TxEip4844Variant to
// TxEip4844Variant<BlobTransactionSidecarVariant>
let (variant, sig, hash) = tx.into_parts();
let blob_variant = match variant {
TxEip4844Variant::TxEip4844(tx) => TxEip4844Variant::TxEip4844(tx),
TxEip4844Variant::TxEip4844WithSidecar(tx_with_sidecar) => {
TxEip4844Variant::TxEip4844WithSidecar(
TxEip4844WithSidecar::from_tx_and_sidecar(
tx_with_sidecar.tx,
BlobTransactionSidecarVariant::Eip4844(tx_with_sidecar.sidecar),
),
)
}
};
Ok(Self::EIP4844(Signed::new_unchecked(blob_variant, sig, hash)))
}
TxEnvelope::Eip7702(tx) => Ok(Self::EIP7702(tx)),
},
AnyTxEnvelope::Unknown(mut tx) => {
Expand Down Expand Up @@ -738,7 +779,7 @@ impl TypedTransaction {
}
}

pub fn sidecar(&self) -> Option<&TxEip4844WithSidecar> {
pub fn sidecar(&self) -> Option<&TxEip4844WithSidecar<BlobTransactionSidecarVariant>> {
match self {
Self::EIP4844(signed_variant) => match signed_variant.tx() {
TxEip4844Variant::TxEip4844WithSidecar(with_sidecar) => Some(with_sidecar),
Expand Down Expand Up @@ -1013,7 +1054,7 @@ impl Encodable2718 for TypedTransaction {
Self::Legacy(tx) => TxEnvelope::from(tx.clone()).encode_2718_len(),
Self::EIP2930(tx) => TxEnvelope::from(tx.clone()).encode_2718_len(),
Self::EIP1559(tx) => TxEnvelope::from(tx.clone()).encode_2718_len(),
Comment on lines 1038 to 1040
Copy link
Member

@mattsse mattsse Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even those from calls here are redundant,

if you want, please submit this separately

Self::EIP4844(tx) => TxEnvelope::from(tx.clone()).encode_2718_len(),
Self::EIP4844(tx) => tx.encode_2718_len(),
Self::EIP7702(tx) => TxEnvelope::from(tx.clone()).encode_2718_len(),
Self::Deposit(tx) => 1 + tx.length(),
}
Expand All @@ -1024,7 +1065,7 @@ impl Encodable2718 for TypedTransaction {
Self::Legacy(tx) => TxEnvelope::from(tx.clone()).encode_2718(out),
Self::EIP2930(tx) => TxEnvelope::from(tx.clone()).encode_2718(out),
Self::EIP1559(tx) => TxEnvelope::from(tx.clone()).encode_2718(out),
Self::EIP4844(tx) => TxEnvelope::from(tx.clone()).encode_2718(out),
Self::EIP4844(tx) => tx.encode_2718(out),
Self::EIP7702(tx) => TxEnvelope::from(tx.clone()).encode_2718(out),
Self::Deposit(tx) => {
tx.encode_2718(out);
Expand All @@ -1041,7 +1082,22 @@ impl Decodable2718 for TypedTransaction {
match TxEnvelope::typed_decode(ty, buf)? {
TxEnvelope::Eip2930(tx) => Ok(Self::EIP2930(tx)),
TxEnvelope::Eip1559(tx) => Ok(Self::EIP1559(tx)),
TxEnvelope::Eip4844(tx) => Ok(Self::EIP4844(tx)),
TxEnvelope::Eip4844(tx) => {
// Convert from TxEip4844Variant to TxEip4844Variant<BlobTransactionSidecarVariant>
let (variant, sig, hash) = tx.into_parts();
let blob_variant = match variant {
TxEip4844Variant::TxEip4844(tx) => TxEip4844Variant::TxEip4844(tx),
TxEip4844Variant::TxEip4844WithSidecar(tx_with_sidecar) => {
TxEip4844Variant::TxEip4844WithSidecar(
TxEip4844WithSidecar::from_tx_and_sidecar(
tx_with_sidecar.tx,
BlobTransactionSidecarVariant::Eip4844(tx_with_sidecar.sidecar),
),
)
}
};
Ok(Self::EIP4844(Signed::new_unchecked(blob_variant, sig, hash)))
}
TxEnvelope::Eip7702(tx) => Ok(Self::EIP7702(tx)),
_ => Err(Eip2718Error::RlpError(alloy_rlp::Error::Custom("unexpected tx type"))),
}
Expand All @@ -1061,7 +1117,22 @@ impl From<TxEnvelope> for TypedTransaction {
TxEnvelope::Legacy(tx) => Self::Legacy(tx),
TxEnvelope::Eip2930(tx) => Self::EIP2930(tx),
TxEnvelope::Eip1559(tx) => Self::EIP1559(tx),
TxEnvelope::Eip4844(tx) => Self::EIP4844(tx),
TxEnvelope::Eip4844(tx) => {
// Convert from TxEip4844Variant to TxEip4844Variant<BlobTransactionSidecarVariant>
let (variant, sig, hash) = tx.into_parts();
let blob_variant = match variant {
TxEip4844Variant::TxEip4844(tx) => TxEip4844Variant::TxEip4844(tx),
TxEip4844Variant::TxEip4844WithSidecar(tx_with_sidecar) => {
TxEip4844Variant::TxEip4844WithSidecar(
TxEip4844WithSidecar::from_tx_and_sidecar(
tx_with_sidecar.tx,
BlobTransactionSidecarVariant::Eip4844(tx_with_sidecar.sidecar),
),
)
}
};
Self::EIP4844(Signed::new_unchecked(blob_variant, sig, hash))
}
TxEnvelope::Eip7702(tx) => Self::EIP7702(tx),
}
}
Expand Down
Loading
Loading