Skip to content

update axum to 0.8 #9986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update axum to 0.8 #9986

wants to merge 2 commits into from

Conversation

getong
Copy link
Contributor

@getong getong commented Mar 1, 2025

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@getong getong force-pushed the update-axum-0.8 branch 2 times, most recently from 147c2ef to b9a257c Compare March 11, 2025 08:18
@getong
Copy link
Contributor Author

getong commented Mar 11, 2025

@DaniPopes
This pr all test passed

@getong getong force-pushed the update-axum-0.8 branch 5 times, most recently from 61f50ec to ec8f9a2 Compare March 12, 2025 04:13
@getong
Copy link
Contributor Author

getong commented Mar 12, 2025

How about this pr? It has passed for many time ci test. @DaniPopes

yash-atreya
yash-atreya previously approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes
Copy link
Member

DaniPopes commented Mar 13, 2025 •
edited
Loading

This is fine however it won't remove axum 0.7 due to gcloud-sdk -> tonic -> axum 0.7

@getong
Copy link
Contributor Author

getong commented Apr 13, 2025

wait for alloy-rs/alloy#2317

@jenpaff jenpaff moved this to Ready For Review in Foundry Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-atreya yash-atreya yash-atreya left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Ready For Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@getong @DaniPopes @yash-atreya