Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make uSD Card Image for the Audio Mini #24
Make uSD Card Image for the Audio Mini #24
Changes from all commits
db752d8
2410010
38c1200
9d307c8
df636b1
a267e07
6407f6f
0fd9ae9
69a9475
3df87d6
f1e9603
c9114a3
15af6d6
e70f659
b6cbc39
94cdf72
9ffd5b1
85b9f06
7f62cfe
d2c971b
e79e29b
2a6994c
7b8c12c
edf1aff
5054c4c
5c99ec4
62632b1
7245d7c
ed74a31
80ff667
1c688ae
7fbac51
372db95
954ef05
226793e
6868616
8f91a9e
51025f7
7e0080c
abce0d0
2b6b53d
78ac910
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this preserve symbolic links? I guess if the final image works, then it doesn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe it does given the
-h
is described asfollow symlinks; archive and dump the files they point to
(it does the same for hardlinks as well).I feel like presently we are using the
-h
out of necessity because I recall problems when extracting without that flag but I would have to investigate further to know what problems we are running into without it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. So links are just being replaced by the files.
From my recollection, things will be messed up, and probably won't boot, if links are ignored. I recall running into issues where things like
/bin/sh
couldn't be found, leading to kernel panics.I believe
-p
preserves symbolic links, which would be an alternative to-h
.