[WIP] ngio refactor #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will also drop Python 3.9 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the plugin to use ngio instead of the custom OMEZarrImage class.
This is WIP, see FIXMEs added. Also, it should be able to drop the fractal-tasks-core dependency. Only tricky part will be the well metadata loading.
This will need to be thoroughly tested. One new restriction it introduces: It can now only load correctly typed ROI & feature tables. The old version was tolerant to e.g. untyped tables if they contained the right content, the ngio version won't be anymore.