fix handling of undef/empty values

fraenki · Nov 30, 2023 · be2855e · be2855e
1 parent 8b40533
commit be2855e
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/manifests/config.pp b/manifests/config.pp
@@ -17,16 +17,8 @@
   }
 
   $_config.each | String $option, Variant[String, Integer, Undef] $value| {
-    if ($value != '') {
-      file_line { "set f-upgrade option ${option}":
-        ensure             => 'present',
-        path               => $f_upgrade::config_file,
-        line               => "${option}=\'${$value}\'",
-        match              => "^${option}=",
-        append_on_no_match => true,
-      }
-    } else {
-      # When $value is set to an empty string, remove the option from
+    if (($value =~ Undef) or ($value == '')) {
+      # When no $value is set, remove the option from
       # the configuration files.
       file_line { "remove f-upgrade option ${option}":
         ensure            => 'absent',
@@ -35,6 +27,14 @@
         match_for_absence => true,
         multiple          => true,
       }
+    } else {
+      file_line { "set f-upgrade option ${option}":
+        ensure             => 'present',
+        path               => $f_upgrade::config_file,
+        line               => "${option}=\'${$value}\'",
+        match              => "^${option}=",
+        append_on_no_match => true,
+      }
     }
   }
 }