zero copy read impl #127
Open
zero copy read impl #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorstewart
force-pushed
the
zero-copy-read
branch
from
528c866 to
96b7436
Compare
victorstewart
force-pushed
the
zero-copy-read
branch
from
79f2842 to
b37a954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR enables the ability to enable the construction of an offset table during serialization, that enables zero copy reads out of a Bitsery serialized buffer.
several years ago i mentioned wanting this zero copy functionality (similar to Flatbuffers), and i think i finally thought of the perfect way to do it. (and once we get Reflection in C++26, we can drop the FieldRegistry code completely and it can all be automatic). i ran some perf tests and this appears on my side to be zero-cost, as in you don't pay for it at all unless you enable it.
i'm sure you'll have some thoughts, so let's discuss if you want any redesigns.