Skip to content

Support permissions in CMS Starter #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: fix/cms-starter-clean-up
Choose a base branch
from

Conversation

alecmev
Copy link
Contributor

@alecmev alecmev commented Apr 9, 2025

Description

Warning: To be merged when permissions are out of beta!

  • In sync mode: Exits on success. Shows UI on failure or if missing permissions.
  • In management mode: Shows UI regardless.
  • Disables the UI if missing permissions, puts an explanation title on the import button.

Testing

  • Steps:
  1. Follow the account setup steps from this PR: https://github.com/framer/FramerStudio/pull/21714
  2. Try relevant permutations of permissions in both plugin modes (including while open).

@alecmev alecmev requested a review from triozer April 9, 2025 17:16
@jonastreub
Copy link
Contributor

Looking at the screenshot you shared I would expect all inputs to be disabled. And I think the Insufficient Permissions text is really ugly. Just disabling the button should be clear enough. Maybe we could add that text in the title tooltip of the button if you think that is helpful

@alecmev alecmev force-pushed the feature/cms-starter-permissions branch from a0c2aa1 to 7614f82 Compare April 11, 2025 12:15
Copy link
Contributor

@jonastreub jonastreub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏

@alecmev alecmev force-pushed the feature/cms-starter-permissions branch from 7614f82 to 6d1607d Compare April 11, 2025 13:46
@alecmev alecmev mentioned this pull request Apr 11, 2025
1 task
@alecmev alecmev changed the base branch from main to fix/cms-starter-clean-up April 11, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants