Heavy spi module refactor #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"master" semantics are just for compatibility at this point
rely more on devm_ allocations & don't worry about freeing them
We can deduce it
The cs handling is done via the kernel, although I'de like to find out how to control them all individually.
|
Okay yeah I got clued in about multiple devices and spi does fail to load on the second device plugged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes advantage of existing kernel procedures for gpio handling mostly, some resource management and device loading too.
Oh, this actually doesn't work because:
devm_spi_register_masterdoes automatically allocation CS pins, but looks them up in a table with a device it literally just named (??)Also regresses the spi driver behaviour by claiming all CS pins / spi busses immediately. It would be cool to be able to load/unload individual busses individually (like we've previously been able to do), if there's some convention on how to do that within the kernel that would be a good start. This probably also means not relying on the kernel's csgpiod handling as much.