colors #1
Closed
colors #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franleplant
reviewed
Jun 28, 2018
| sat = 100; | ||
| light = (shade?60:70)-((((increase*index)) / 360)*8); | ||
|
|
||
| var color="hsl("+hue+","+sat+"%,"+light+"%)"; |
|
|
||
| hue = ((startHue+(increase*index)) % 360); | ||
| sat = 100; | ||
| light = (shade?60:70)-((((increase*index)) / 360)*8); |
There was a problem hiding this comment.
declara cada variable con const en cada linea
There was a problem hiding this comment.
es documentacion semantica, los proximos desarrolladores entienden que esas variables se pueden procesar antes de outputearlas
|
E no
…On Thu, Jun 28, 2018, 00:45 IgnacioAmigo ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In client/src/App.js
<#1 (comment)>:
> @@ -54,6 +54,20 @@ function transform(cells) {
pointHitRadius: 10
};
+
+ function getColor(index,shade){
+ const startHue= 0;
+ const increase=37;
+ var hue,sat,light;
+
+ hue = ((startHue+(increase*index)) % 360);
+ sat = 100;
+ light = (shade?60:70)-((((increase*index)) / 360)*8);
es documentacion semantica, los proximos desarrolladores entienden que
esas variables se pueden procesar antes de outputearlas
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABxEJ2dgxQT0PF49A9MhqiedGV-aK4t0ks5uBFFEgaJpZM4U6pLd>
.
|
|
que raro que es esto del mundo javascript |
|
Indeed, pero si tenes en el corazon langs funcionales entonces todo bien
…On Fri, Jun 29, 2018, 17:28 IgnacioAmigo ***@***.***> wrote:
que raro que es esto del mundo javascript
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABxEJ7PZeR7jPe_FaCMSWQKCc851GJO3ks5uBo3ogaJpZM4U6pLd>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es para romperte las bolas porque no me psusite de contributor nada mas :>