Skip to content

fix: translate remaining untranslated UI strings (empty states, Kanban) #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palamars wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: translate remaining untranslated UI strings (empty states, Kanban) #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
193b6fa
fix(i18n): wrap remaining untranslated strings in __()
palamars Jul 9, 2026
dc78c86
fix(i18n): translate Kanban column headers and field labels
palamars Jul 9, 2026
611f269
fix(i18n): wrap the dropdown list item label too, not just the select…
palamars Jul 9, 2026
14e1834
fix: explicit '' fallback before __() when the routing-option lookup …
palamars Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/components/IconPicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
<FormControl
v-model="search"
type="text"
placeholder="Search by keyword"
:placeholder="__('Search by keyword')"
:debounce="300"
/>
</div>
<Button @click="setRandom">Random</Button>
<Button @click="setRandom">{{ __('Random') }}</Button>
</div>
<div class="w-96"></div>
<div v-for="(emojis, group) in emojiGroups" :key="group" class="px-3">
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/components/Kanban/KanbanSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<template #target="{ togglePopover }">
<Button
class="w-full !justify-start"
:label="columnField.label"
:label="__(columnField.label)"
@click="togglePopover()"
/>
</template>
Expand All @@ -36,7 +36,7 @@
<template #target="{ togglePopover }">
<Button
class="w-full !justify-start"
:label="titleField.label"
:label="__(titleField.label)"
@click="togglePopover()"
/>
</template>
Expand All @@ -59,7 +59,7 @@
>
<div class="flex items-center gap-2">
<DragVerticalIcon class="h-3.5 cursor-grab" />
<div>{{ field.label }}</div>
<div>{{ __(field.label) }}</div>
</div>
<div>
<Button
Expand All @@ -82,7 +82,7 @@
</template>
<template #item-label="{ option }">
<div class="flex flex-col gap-1 text-ink-gray-9">
<div>{{ option.label }}</div>
<div>{{ __(option.label) }}</div>
<div class="text-ink-gray-4 text-sm">
{{ `${option.fieldname} - ${option.fieldtype}` }}
</div>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Kanban/KanbanView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
</div>
</template>
</Popover>
<div class="text-ink-gray-9">{{ column.column.name }}</div>
<div class="text-ink-gray-9">{{ __(column.column.name) }}</div>
</div>
<div class="flex">
<Dropdown :options="actions(column)">
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/ListViews/EmptyState.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ const props = defineProps({
})

const computedTitle = computed(() => {
return props.title ? props.title : __('No {0} Found', [__(props.name)])
return props.title ? __(props.title) : __('No {0} Found', [__(props.name)])
})

const computedDescription = computed(() => {
return props.description
? props.description
? __(props.description)
: __(
'It appears that there are currently no {0} available. You can create more {0} by using the Create button.',
[__(props.name)],
Expand Down
10 changes: 6 additions & 4 deletions frontend/src/components/Settings/AssignmentRules/AssigneeRules.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@
>
<div>
{{
documentRoutingOptions.find(
(option) => option.value == assignmentRuleData.rule,
)?.label
__(
documentRoutingOptions.find(
(option) => option.value == assignmentRuleData.rule,
)?.label || '',
)
Comment thread
greptile-apps[bot] marked this conversation as resolved.
}}
</div>
<span class="lucide-chevron-down size-4" aria-hidden="true" />
Expand All @@ -62,7 +64,7 @@
"
>
<span>
{{ option.label }}
{{ __(option.label) }}
</span>
<span
v-if="assignmentRuleData.rule == option.value"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Settings/Profile/UserEmailSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<TextEditor
editor-class="prose-sm min-h-28 max-w-full border rounded-b-lg border-t-0 p-2 border-outline-elevation-2"
:content="user.doc.email_signature"
placeholder="Type something..."
:placeholder="__('Type something...')"
:bubbleMenu="true"
:fixed-menu="true"
@change="(val) => (user.doc.email_signature = val)"
Expand Down