fix(list): align deals like button with its column header (backport #2602) - #2603
Open
mergify[bot] wants to merge 1 commit into
Open
fix(list): align deals like button with its column header (backport #2602)#2603mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
The deals list rendered the `_liked_by` heart in the ListRowItem `#prefix` slot, which left an empty label as a second flex item in `#default`. With the column right-aligned (`justify-end` + `gap-2`), that empty label pinned to the cell's right edge and the gap pushed the heart ~8px left of the column-header heart. Move the heart to `#default` — matching every other list view (Leads, Contacts, Call Logs, Tasks, Organizations) — so it's the sole item in the cell and stays flush-right, aligned with the header. (cherry picked from commit ce02333)
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The like (heart) column in the Deals list was misaligned — the row hearts sat ~8px left of the column-header heart. Every other list view (Leads, Contacts, Call Logs, Tasks, Organizations) was already correct.
Cause
DealsListViewrendered the_liked_byheart in theListRowItem#prefixslot. That left an empty label as a second flex item in#default; with the column right-aligned (justify-end+gap-2), the empty label pinned to the cell's right edge and the gap pushed the heart ~8px left. The other views render the heart in#default, so it's the only item in the cell and stays flush-right.Fix
Move the heart from
#prefixto#defaultinDealsListView, matching the other list views.Testing
Measured the header vs. row heart centers in the rendered deals list:
Before
After
This is an automatic backport of pull request #2602 done by [Mergify](https://mergify.com).