feat: Announcement page to display announcements from newsletters on student portal#319
feat: Announcement page to display announcements from newsletters on student portal#319maniamartial wants to merge 5 commits intofrappe:developfrom
Conversation
|
Hi Mania This is seems like a useful feature. Can you use FrappeUI's list view instead of custom cards? In the dialog, "Close" should be just the close icon that will appear by default in FrappeUI's dialog. |
Sure, refactoring. |
|
Let's remove the calendar emoji and use a formatted date (like 3 hours ago etc.) |
|
Also, your commit message formats are not consistent: ":", "-", etc. as separator. We stick to conventional commits. Please reformat those using rebase. |
|
Also, can you fix the dialog UI and update screenshots in PR description? |
7d8e27f to
56ed63f
Compare
Seen, done |



User creates new newsletter from the Newsletter doctype. Then publish the announcement

Then on the students, click on the Announcement button on sidebar, it will display all announcements

Then you can click on each announcement to see the message which will appear like a dialog box
