fix(central): read storage and telemetry from their own instance metadata attributes - #532
Merged
prathameshkurunkar7 merged 3 commits intoSep 25, 2026
Conversation
…data attributes Central now sends pilot-storage and pilot-telemetry apart from pilot-central, because the cloud caps each metadata value at 1 KiB.
Contributor
|
tanmoysrt
reviewed
Sep 25, 2026
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Pilot read storage and telemetry from
pilot-central. That value is now too large for the cloud's 1 KiB limit.Summary
Pilot reads storage from
pilot-storageand telemetry frompilot-telemetry. Both are optional.What changed
InstanceMetadata.get_credentialsreads each block from its own attribute.pilot-centralare ignored.Central side: frappe/central#376