Skip to content

fix(central): read storage and telemetry from their own instance metadata attributes - #532

Merged
prathameshkurunkar7 merged 3 commits into
frappe:developfrom
prathameshkurunkar7:fix/pilot-storage-metadata
Sep 25, 2026
Merged

prathameshkurunkar7 merged 3 commits into
frappe:developfrom
prathameshkurunkar7:fix/pilot-storage-metadata

Conversation

@prathameshkurunkar7

@prathameshkurunkar7 prathameshkurunkar7 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Issue

Pilot read storage and telemetry from pilot-central. That value is now too large for the cloud's 1 KiB limit.

Summary

Pilot reads storage from pilot-storage and telemetry from pilot-telemetry. Both are optional.

What changed

  • InstanceMetadata.get_credentials reads each block from its own attribute.
  • Blocks inside pilot-central are ignored.

Central side: frappe/central#376

…data attributes

Central now sends pilot-storage and pilot-telemetry apart from pilot-central, because the cloud caps each metadata value at 1 KiB.
@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Refactors how storage and telemetry metadata are read.

The PR appears safe to merge.

Reviews (3) · Last reviewed commit: "fix(central): type the metadata blocks f..."

Comment thread pilot/integrations/central/metadata.py Outdated
Comment thread pilot/integrations/central/metadata.py
Comment thread pilot/integrations/central/metadata.py
Comment thread pilot/integrations/central/metadata.py Outdated
@prathameshkurunkar7

Copy link
Copy Markdown
Contributor Author

@greptileai review

@prathameshkurunkar7
prathameshkurunkar7 merged commit 28a2600 into frappe:develop Sep 25, 2026
6 checks passed
@prathameshkurunkar7
prathameshkurunkar7 deleted the fix/pilot-storage-metadata branch September 25, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants