feat(site): skip the drop backup for failed new sites and from the drop dialog - #535
Open
mihir-kandoi wants to merge 3 commits into
Open
mihir-kandoi wants to merge 3 commits into
mihir-kandoi wants to merge 3 commits into
Conversation
A new site that failed or was cancelled holds no user data, so the full dump frappe drop-site takes first is wasted work and leaves a junk backup.
Adds a "Take a backup before dropping" checkbox, checked by default. Unchecking it sends DELETE /sites/<name>?no_backup=1, so large sites can be dropped without frappe taking a full dump first.
mihir-kandoi
added this pull request to stack #536
September 26, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #534.
no_backup=True; it has no user data, so the full dump was wasted work.DELETE /sites/<name>?no_backup=1.