Skip to content

Fix: don't download chromium if it is configured and installed #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trustedcomputer wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: don't download chromium if it is configured and installed #490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33a3b3
Fix: don't download chromium if it is configured and installed
trustedcomputer Nov 3, 2025
e24fbd5
Merge branch 'frappe:develop' into trustedcomputer-check-for-configur…
trustedcomputer Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions print_designer/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,18 @@ def make_chromium_executable(executable):


def find_or_download_chromium_executable():

"""Fetch from common site config, if present"""
site_config = frappe.get_common_site_config()
chromium_binary_path = site_config.get("chromium_binary_path", "")
if chromium_binary_path:
exec_path = Path(chromium_binary_path)
if exec_path.exists():
return str(exec_path)
else:
click.echo("Chromium is not available at the configured path. Downloading...")
download_chromium()

"""Finds the Chromium executable or downloads if not found."""
bench_path = frappe.utils.get_bench_path()
"""Determine the path to the Chromium executable."""
Expand Down