feat: add rule to enforce whitelist_for_tests in test files#36
Merged
ankush merged 3 commits intofrappe:developfrom Feb 5, 2026
Merged
feat: add rule to enforce whitelist_for_tests in test files#36ankush merged 3 commits intofrappe:developfrom
ankush merged 3 commits intofrappe:developfrom
Conversation
Adds semgrep rule to detect when test endpoints use @frappe.whitelist() instead of @whitelist_for_tests(). This ensures test endpoints are properly protected and only accessible in test environments.
sagarvora
force-pushed
the
add-whitelist-for-tests-rule
branch
from
b18a1f5 to
b8d8401
Compare
sagarvora
force-pushed
the
add-whitelist-for-tests-rule
branch
from
36c8247 to
cf8eb22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds semgrep rule to detect when test endpoints use
@frappe.whitelist()instead of@whitelist_for_tests(). This ensures test endpoints are properly protected and only accessible in test environments.