Add /etc/pki/tls/certs/ directory to file checker#359
Merged
rcritten merged 1 commit intofreeipa:masterfrom Jul 7, 2025
Merged
Add /etc/pki/tls/certs/ directory to file checker#359rcritten merged 1 commit intofreeipa:masterfrom
rcritten merged 1 commit intofreeipa:masterfrom
Conversation
In order to load the CA bundle /etc/pki/tls/certs needs to be world-readable. That or the group needs to change if someone wants to get really restrictive but that's likely to cause further unforseen issues elsewhere. This directory contains only public information. Restrictive permissions will cause pki-tomcatd to fail to start. Fixes: freeipa#358 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Contributor
|
Hi @rcritten thanks for the patch, LGTM. Tested on a f42 machine: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to load the CA bundle /etc/pki/tls/certs needs to be world-readable. That or the group needs to change if someone wants to get really restrictive but that's likely to cause further unforseen issues elsewhere. This directory contains only public information.
Restrictive permissions will cause pki-tomcatd to fail to start.
Fixes: #358
Summary by Sourcery
Add the OpenSSL certs directory to the permission checks to ensure /etc/pki/tls/certs is accessible, fixing related startup errors
Bug Fixes:
Enhancements: